Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1330563005: Introduce VisiblePositionTemplate template class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce VisiblePositionTemplate template class This patch introduces template class |VisiblePositionTemplate| like |PositionWithAffinityTemplate| as a preparation of introduce composed tree version of |VisiblePosition|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201765

Patch Set 1 : 2015-09-04T10:27:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M Source/core/editing/VisiblePosition.h View 2 chunks +19 lines, -11 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 3 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
yoichio
lgtm
5 years, 3 months ago (2015-09-04 01:53:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330563005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330563005/1
5 years, 3 months ago (2015-09-04 02:28:38 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 03:20:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201765

Powered by Google App Engine
This is Rietveld 408576698