Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1330563005: Introduce VisiblePositionTemplate template class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-04T10:27:43 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 0a4907258c5545ff010598c7bf4e94642d9587fc..f265f6e61e1da690cf93bb7606d06a48beff756b 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -49,18 +49,21 @@ namespace blink {
using namespace HTMLNames;
-VisiblePosition::VisiblePosition()
+template <typename Strategy>
+VisiblePositionTemplate<Strategy>::VisiblePositionTemplate()
{
}
-VisiblePosition::VisiblePosition(const PositionWithAffinity& positionWithAffinity)
+template <typename Strategy>
+VisiblePositionTemplate<Strategy>::VisiblePositionTemplate(const PositionWithAffinityTemplate<Strategy>& positionWithAffinity)
: m_positionWithAffinity(positionWithAffinity)
{
}
-VisiblePosition VisiblePosition::createWithoutCanonicalization(const PositionWithAffinity& canonicalized)
+template <typename Strategy>
+VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::createWithoutCanonicalization(const PositionWithAffinityTemplate<Strategy>& canonicalized)
{
- return VisiblePosition(canonicalized);
+ return VisiblePositionTemplate<Strategy>(canonicalized);
}
template<typename Strategy>
@@ -97,7 +100,8 @@ VisiblePosition createVisiblePosition(const PositionInComposedTree& position, Te
#ifndef NDEBUG
-void VisiblePosition::debugPosition(const char* msg) const
+template<typename Strategy>
+void VisiblePositionTemplate<Strategy>::debugPosition(const char* msg) const
{
if (isNull()) {
fprintf(stderr, "Position [%s]: null\n", msg);
@@ -106,22 +110,21 @@ void VisiblePosition::debugPosition(const char* msg) const
deepEquivalent().debugPosition(msg);
}
-void VisiblePosition::formatForDebugger(char* buffer, unsigned length) const
+template<typename Strategy>
+void VisiblePositionTemplate<Strategy>::formatForDebugger(char* buffer, unsigned length) const
{
deepEquivalent().formatForDebugger(buffer, length);
}
-void VisiblePosition::showTreeForThis() const
+template<typename Strategy>
+void VisiblePositionTemplate<Strategy>::showTreeForThis() const
{
deepEquivalent().showTreeForThis();
}
#endif
-DEFINE_TRACE(VisiblePosition)
-{
- visitor->trace(m_positionWithAffinity);
-}
+template class CORE_TEMPLATE_EXPORT VisiblePositionTemplate<EditingStrategy>;
} // namespace blink
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698