Issue 133053003: linux_aura: Fix dragging files into Dropbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133053003: linux_aura: Fix dragging files into Dropbox. (Closed)

Created:
6 years, 11 months ago by Elliot Glaysher

Modified:
6 years, 11 months ago

Reviewers:
sky, dcheng

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_aura: Fix dragging files into Dropbox. Some Linux file managers will set both URI list representation and the plain text representation when dragging files. Chrome interprets this as a chunk of text and a file, and offers both to the renderer. This broke the javascript on the Dropbox website. This ports the hack in WebDragDestGtk::OnDragDataReceived() to linux_aura. This hack prevents us from offering the String type when we also have a URI list. BUG=318796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244315

Patch Set 1 #

Patch Set 2 : Simplify #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	ui/base/dragdrop/os_exchange_data_provider_aurax11.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
	M	ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

sky: review dcheng: fyi, since you pointed out what was wrong.

6 years, 11 months ago (2014-01-10 02:03:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/133053003/30001

6 years, 11 months ago (2014-01-10 18:43:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/133053003/30001

6 years, 11 months ago (2014-01-10 23:42:40 UTC) #4

Message was sent while issue was closed.

Change committed as 244315

Expand Messages | Collapse Messages