Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330453002: Cleanup DisplayItemList::processNewItem to take a reference (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup DisplayItemList::processNewItem to take a reference This patch fixes an old TODO where processNewItem took a pointer to make the initial review easier. The pointer indirection is not necessary and has been switched to a reference. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M Source/platform/graphics/paint/DisplayItemList.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pdr.
5 years, 3 months ago (2015-09-02 05:34:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330453002/1
5 years, 3 months ago (2015-09-02 05:34:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 06:41:51 UTC) #6
chrishtr
lgtm
5 years, 3 months ago (2015-09-02 17:43:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330453002/1
5 years, 3 months ago (2015-09-02 17:43:41 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 17:48:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201657

Powered by Google App Engine
This is Rietveld 408576698