Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2258)

Unified Diff: Source/platform/graphics/paint/DisplayItemList.h

Issue 1330453002: Cleanup DisplayItemList::processNewItem to take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/graphics/paint/DisplayItemList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DisplayItemList.h
diff --git a/Source/platform/graphics/paint/DisplayItemList.h b/Source/platform/graphics/paint/DisplayItemList.h
index 84ef3f1a839b38836158bd9ce364569e41e14ad5..bd97e79a1728c785077ef6609b78705f822752b2 100644
--- a/Source/platform/graphics/paint/DisplayItemList.h
+++ b/Source/platform/graphics/paint/DisplayItemList.h
@@ -70,7 +70,7 @@ public:
"DisplayItem subclass is larger than kMaximumDisplayItemSize.");
DisplayItemClass& displayItem = m_newDisplayItems.allocateAndConstruct<DisplayItemClass>(WTF::forward<Args>(args)...);
- processNewItem(&displayItem);
+ processNewItem(displayItem);
return displayItem;
}
@@ -157,8 +157,7 @@ private:
friend class LayoutObjectDrawingRecorderTestForSlimmingPaintV2;
// Set new item state (scopes, cache skipping, etc) for a new item.
- // TODO(pdr): This only passes a pointer to make the patch easier to review. Change to a reference.
- void processNewItem(DisplayItem*);
+ void processNewItem(DisplayItem&);
void updateValidlyCachedClientsIfNeeded() const;
« no previous file with comments | « no previous file | Source/platform/graphics/paint/DisplayItemList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698