CSS escape doesn't escape leading hyphen.

CSS escape doesn't escape leading hyphen.

As per the spec
https://drafts.csswg.org/cssom/#serialize-an-identifier
If the character is the first character and is a '-' (U+002D), and
there is no second character, then it should be escaped.

BUG=528972
Committed: https://crrev.com/b000368e89cd7e755f91623ad6f6460883d056eb
git-svn-id: svn://svn.chromium.org/blink/trunk@202039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[ramya.v, 2015-09-10 07:17:22]

ramya.v@samsung.com changed reviewers:
+ rob.buis@samsung.com, timloh@chromium.org

[ramya.v, 2015-09-10 07:17:23]

PTAL!

Thanks

[Timothy Loh, 2015-09-10 07:21:25]

On 2015/09/10 07:17:23, ramya.v wrote:
> PTAL!
> 
> Thanks

Does this handle the ident "--" correctly? Looks like this would result in -\-.

[ramya.v, 2015-09-10 07:32:24]

On 2015/09/10 07:21:25, Timothy Loh wrote:
> On 2015/09/10 07:17:23, ramya.v wrote:
> > PTAL!
> > 
> > Thanks
> 
> Does this handle the ident "--" correctly? Looks like this would result in
-\-.

Sorry my mistake, had this testcase in mind. Updated in patch set2. PTAL!


Thanks

[Timothy Loh, 2015-09-10 07:37:41]

On 2015/09/10 07:32:24, ramya.v wrote:
> On 2015/09/10 07:21:25, Timothy Loh wrote:
> > On 2015/09/10 07:17:23, ramya.v wrote:
> > > PTAL!
> > > 
> > > Thanks
> > 
> > Does this handle the ident "--" correctly? Looks like this would result in
> -\-.
> 
> Sorry my mistake, had this testcase in mind. Updated in patch set2. PTAL!
> 
> 
> Thanks

lgtm

[Timothy Loh, 2015-09-10 07:38:36]

On 2015/09/10 07:37:41, Timothy Loh wrote:
> On 2015/09/10 07:32:24, ramya.v wrote:
> > On 2015/09/10 07:21:25, Timothy Loh wrote:
> > > On 2015/09/10 07:17:23, ramya.v wrote:
> > > > PTAL!
> > > > 
> > > > Thanks
> > > 
> > > Does this handle the ident "--" correctly? Looks like this would result in
> > -\-.
> > 
> > Sorry my mistake, had this testcase in mind. Updated in patch set2. PTAL!
> > 
> > 
> > Thanks
> 
> lgtm

You probably want the description to point to
https://drafts.csswg.org/cssom/#serialize-an-identifier

[ramya.v, 2015-09-10 07:41:37]

On 2015/09/10 07:38:36, Timothy Loh wrote:
> On 2015/09/10 07:37:41, Timothy Loh wrote:
> > On 2015/09/10 07:32:24, ramya.v wrote:
> > > On 2015/09/10 07:21:25, Timothy Loh wrote:
> > > > On 2015/09/10 07:17:23, ramya.v wrote:
> > > > > PTAL!
> > > > > 
> > > > > Thanks
> > > > 
> > > > Does this handle the ident "--" correctly? Looks like this would result
in
> > > -\-.
> > > 
> > > Sorry my mistake, had this testcase in mind. Updated in patch set2. PTAL!
> > > 
> > > 
> > > Thanks
> > 
> > lgtm
> 
> You probably want the description to point to
> https://drafts.csswg.org/cssom/#serialize-an-identifier

Thanks Tim, updated description.

[ramya.v, 2015-09-10 07:41:57]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2015-09-10 07:42:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330243002/20001

[commit-bot: I haz the power, 2015-09-10 08:49:08]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202039

[mathias, 2015-09-10 10:13:04]

mathias@qiwi.be changed reviewers:
+ mathias@qiwi.be

[mathias, 2015-09-10 10:13:04]

https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
File LayoutTests/css3/escape-dom-api.html (right):

https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
LayoutTests/css3/escape-dom-api.html:57:
shouldBeEqualToString("CSS.escape('-')", "\\-");
To match the updated source tests, add this:

    shouldBeEqualToString("CSS.escape('-a')", "-a");

See
https://github.com/mathiasbynens/CSS.escape/blob/a936627f36f58a271a11eb295896...

[mathias, 2015-09-10 10:20:25]

https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
File LayoutTests/css3/escape-dom-api.html (right):

https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
LayoutTests/css3/escape-dom-api.html:58:
shouldBeEqualToString("CSS.escape('--')", "--");
This test expectation is incorrect. It should be `-\\-`.

See the spec: “If the character is the second character and is a `-` (U+002D),
and the first character is also a `-` (U+002D), and there is no third character,
[…]”

[mathias, 2015-09-10 10:22:53]

On 2015/09/10 10:20:25, mathias wrote:
>
https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
> File LayoutTests/css3/escape-dom-api.html (right):
> 
>
https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
> LayoutTests/css3/escape-dom-api.html:58:
> shouldBeEqualToString("CSS.escape('--')", "--");
> This test expectation is incorrect. It should be `-\\-`.
> 
> See the spec: “If the character is the second character and is a `-` (U+002D),
> and the first character is also a `-` (U+002D), and there is no third
character,
> […]”

My bad, I missed this spec update:
https://github.com/w3c/csswg-drafts/commit/7707b15e6d42a6cb4b04da6b6ecb680c0e...
The current implementation is perfect!

[ramya.v, 2015-09-10 11:41:02]

On 2015/09/10 10:13:04, mathias wrote:
>
https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
> File LayoutTests/css3/escape-dom-api.html (right):
> 
>
https://codereview.chromium.org/1330243002/diff/20001/LayoutTests/css3/escape...
> LayoutTests/css3/escape-dom-api.html:57:
> shouldBeEqualToString("CSS.escape('-')", "\\-");
> To match the updated source tests, add this:
> 
>     shouldBeEqualToString("CSS.escape('-a')", "-a");
> 
> See
>
https://github.com/mathiasbynens/CSS.escape/blob/a936627f36f58a271a11eb295896...

Added patch to include tests at
https://codereview.chromium.org/1329413003/

[commit-bot: I haz the power, 2015-09-23 12:08:46]

Patchset 2 (id:??) landed as
https://crrev.com/b000368e89cd7e755f91623ad6f6460883d056eb