Source/core/css/CSSMarkup.cpp - Issue 1330243002: CSS escape doesn't escape leading hyphen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSMarkup.cpp

Issue 1330243002: CSS escape doesn't escape leading hyphen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated patch to handle '--' Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSMarkup.cpp

diff --git a/Source/core/css/CSSMarkup.cpp b/Source/core/css/CSSMarkup.cpp

index ce45904ccd859140868b5e7e1aff06edb79062b1..03a3f8910f66615d3012fc57e9e9591d9bc987e8 100644

--- a/Source/core/css/CSSMarkup.cpp

+++ b/Source/core/css/CSSMarkup.cpp

@@ -219,6 +219,8 @@ bool serializeIdentifier(const String& identifier, StringBuilder& appendTo)

if (c <= 0x1f || c == 0x7f || (0x30 <= c && c <= 0x39 && (isFirst || (isSecond && isFirstCharHyphen))))

serializeCharacterAsCodePoint(c, appendTo);

+ else if (c == 0x2d && isFirst && index == identifier.length())

+ serializeCharacter(c, appendTo);

else if (0x80 <= c || c == 0x2d || c == 0x5f || (0x30 <= c && c <= 0x39) || (0x41 <= c && c <= 0x5a) || (0x61 <= c && c <= 0x7a))

appendTo.append(c);

else