Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133023002: Remove unnecessary use of blink typedefs (Closed)

Created:
6 years, 11 months ago by jamesr
Modified:
6 years, 11 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Remove unnecessary use of blink typedefs This replaces uses of blink's WebGraphicsContext3D.h typedefs for GL numeric types with the types from the khronos headers. BUG=181120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244312

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+905 lines, -949 lines) Patch
M cc/output/gl_renderer_unittest.cc View 1 13 chunks +87 lines, -113 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d.h View 1 2 chunks +423 lines, -422 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d.cc View 1 6 chunks +100 lines, -104 lines 0 comments Download
M cc/test/ordered_texture_map.h View 2 chunks +9 lines, -9 lines 0 comments Download
M cc/test/ordered_texture_map.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/test/test_texture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/test_texture.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 7 chunks +118 lines, -124 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 1 23 chunks +109 lines, -117 lines 0 comments Download
M cc/test/test_web_graphics_context_3d_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +25 lines, -25 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
There are still some uses of blink::WebString and blink::WebGraphicsContext3D left behind in cc, but once ...
6 years, 11 months ago (2014-01-10 01:29:56 UTC) #1
enne (OOO)
lgtm
6 years, 11 months ago (2014-01-10 01:34:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/133023002/1
6 years, 11 months ago (2014-01-10 02:08:11 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66463
6 years, 11 months ago (2014-01-10 04:10:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/133023002/1
6 years, 11 months ago (2014-01-10 07:45:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66533
6 years, 11 months ago (2014-01-10 09:41:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/133023002/280001
6 years, 11 months ago (2014-01-10 20:10:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/133023002/280001
6 years, 11 months ago (2014-01-10 23:41:16 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 02:26:39 UTC) #9
Message was sent while issue was closed. 
Change committed as 244312

Powered by Google App Engine
This is Rietveld 408576698