Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330213003: Enable loads and stores to global vars through property cell shortcuts installed into parent script… (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@cr517778
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable loads and stores to global vars through property cell shortcuts installed into parent script context. Committed: https://crrev.com/deb5f524d7e7dd011bc245cb24e83358e22826f8 Cr-Commit-Position: refs/heads/master@{#30684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1335633002 Patch 1

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-09-10 12:30:38 UTC) #2
Benedikt Meurer
LGTM. Weaponize it!
5 years, 3 months ago (2015-09-10 12:34:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330213003/1
5 years, 3 months ago (2015-09-10 14:19:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 14:21:24 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 14:21:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/deb5f524d7e7dd011bc245cb24e83358e22826f8
Cr-Commit-Position: refs/heads/master@{#30684}

Powered by Google App Engine
This is Rietveld 408576698