Issue 133013007: BrowserPlugin: Minimize BrowserPluginEmbedder static casts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133013007: BrowserPlugin: Minimize BrowserPluginEmbedder static casts (Closed)

Created:
6 years, 11 months ago by Fady Samuel

Modified:
6 years, 11 months ago

Reviewers:
sadrul

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

BrowserPlugin: Minimize BrowserPluginEmbedder static casts BUG=330843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244214

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
	M	content/browser/browser_plugin/browser_plugin_embedder.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	content/browser/browser_plugin/browser_plugin_embedder.cc	View		8 chunks	+22 lines, -25 lines	0 comments	Download

Total messages: 5 (0 generated)

sadrul

LGTM Suggestion: how about using something like GetWebContentsImpl(), to clarify whether to use this or ...

6 years, 11 months ago (2014-01-10 16:55:31 UTC) #2

Fady Samuel

On 2014/01/10 16:55:31, sadrul wrote: > LGTM > > Suggestion: how about using something like ...

6 years, 11 months ago (2014-01-10 16:57:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/133013007/1

6 years, 11 months ago (2014-01-10 17:06:59 UTC) #4

Message was sent while issue was closed.

Change committed as 244214