BrowserPlugin: Minimize BrowserPluginEmbedder static casts

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include "base/values.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_manager.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
@@ skipping 63 matching lines @@
   // Store the callback so we can call it later when we have the response.
   pending_get_render_view_callbacks_.insert(
       std::make_pair(next_get_render_view_request_id_, callback));
   Send(new BrowserPluginMsg_PluginAtPositionRequest(
       routing_id(),
       next_get_render_view_request_id_,
       gfx::Point(x, y)));
   ++next_get_render_view_request_id_;
 }
 
+WebContentsImpl* BrowserPluginEmbedder::GetWebContents() {
+  return static_cast<WebContentsImpl*>(web_contents());
+}
+
 bool BrowserPluginEmbedder::DidSendScreenRectsCallback(
    BrowserPluginGuest* guest) {
   static_cast<RenderViewHostImpl*>(
       guest->GetWebContents()->GetRenderViewHost())->SendScreenRects();
   // Not handled => Iterate over all guests.
   return false;
 }
 
 void BrowserPluginEmbedder::DidSendScreenRects() {
-  WebContentsImpl* embedder =
-      static_cast<WebContentsImpl*>(web_contents());
-  GetBrowserPluginGuestManager()->ForEachGuest(embedder, base::Bind(
+  GetBrowserPluginGuestManager()->ForEachGuest(GetWebContents(), base::Bind(
       &BrowserPluginEmbedder::DidSendScreenRectsCallback,
       base::Unretained(this)));
 }
 
 bool BrowserPluginEmbedder::UnlockMouseIfNecessaryCallback(
     const NativeWebKeyboardEvent& event,
     BrowserPluginGuest* guest) {
   return guest->UnlockMouseIfNecessary(event);
 }
 
 bool BrowserPluginEmbedder::HandleKeyboardEvent(
     const NativeWebKeyboardEvent& event) {
   if ((event.type != blink::WebInputEvent::RawKeyDown) ||
       (event.windowsKeyCode != ui::VKEY_ESCAPE) ||
       (event.modifiers & blink::WebInputEvent::InputModifiers)) {
     return false;
   }
 
-  WebContentsImpl* embedder =
-      static_cast<WebContentsImpl*>(web_contents());
-  return GetBrowserPluginGuestManager()->ForEachGuest(embedder, base::Bind(
-      &BrowserPluginEmbedder::UnlockMouseIfNecessaryCallback,
-      base::Unretained(this),
-      event));
+  return GetBrowserPluginGuestManager()->ForEachGuest(GetWebContents(),
+      base::Bind(&BrowserPluginEmbedder::UnlockMouseIfNecessaryCallback,
+                 base::Unretained(this),
+                 event));
 }
 
 bool BrowserPluginEmbedder::SetZoomLevelCallback(
     double level, BrowserPluginGuest* guest) {
   guest->GetWebContents()->SetZoomLevel(level);
   // Not handled => Iterate over all guests.
   return false;
 }
 
 void BrowserPluginEmbedder::SetZoomLevel(double level) {
-  WebContentsImpl* embedder =
-      static_cast<WebContentsImpl*>(web_contents());
-  GetBrowserPluginGuestManager()->ForEachGuest(embedder, base::Bind(
+  GetBrowserPluginGuestManager()->ForEachGuest(GetWebContents(), base::Bind(
       &BrowserPluginEmbedder::SetZoomLevelCallback,
       base::Unretained(this),
       level));
 }
 
 void BrowserPluginEmbedder::RenderProcessGone(base::TerminationStatus status) {
   CleanUp();
 }
 
 bool BrowserPluginEmbedder::OnMessageReceived(const IPC::Message& message) {
@@ skipping 45 matching lines @@
 
 void BrowserPluginEmbedder::CleanUp() {
   // CleanUp gets called when BrowserPluginEmbedder's WebContents goes away
   // or the associated RenderViewHost is destroyed or swapped out. Therefore we
   // don't need to care about the pending callbacks anymore.
   pending_get_render_view_callbacks_.clear();
 }
 
 BrowserPluginGuestManager*
     BrowserPluginEmbedder::GetBrowserPluginGuestManager() {
-  BrowserPluginGuestManager* guest_manager = static_cast<WebContentsImpl*>(
-      web_contents())->GetBrowserPluginGuestManager();
+  BrowserPluginGuestManager* guest_manager =
+      GetWebContents()->GetBrowserPluginGuestManager();
   if (!guest_manager) {
     guest_manager = BrowserPluginGuestManager::Create();
-    web_contents()->GetBrowserContext()->SetUserData(
+    GetWebContents()->GetBrowserContext()->SetUserData(
         browser_plugin::kBrowserPluginGuestManagerKeyName, guest_manager);
   }
   return guest_manager;
 }
 
 void BrowserPluginEmbedder::OnAllocateInstanceID(int request_id) {
   int instance_id = GetBrowserPluginGuestManager()->get_next_instance_id();
   Send(new BrowserPluginMsg_AllocateInstanceID_ACK(
       routing_id(), request_id, instance_id));
 }
 
 void BrowserPluginEmbedder::OnAttach(
     int instance_id,
     const BrowserPluginHostMsg_Attach_Params& params,
     const base::DictionaryValue& extra_params) {
   if (!GetBrowserPluginGuestManager()->CanEmbedderAccessInstanceIDMaybeKill(
-          web_contents()->GetRenderProcessHost()->GetID(), instance_id))
+          GetWebContents()->GetRenderProcessHost()->GetID(), instance_id))
     return;
 
   BrowserPluginGuest* guest =
       GetBrowserPluginGuestManager()->GetGuestByInstanceID(
-          instance_id, web_contents()->GetRenderProcessHost()->GetID());
+          instance_id, GetWebContents()->GetRenderProcessHost()->GetID());
 
   if (guest) {
     // There is an implicit order expectation here:
     // 1. The content embedder is made aware of the attachment.
     // 2. BrowserPluginGuest::Attach is called.
     // 3. The content embedder issues queued events if any that happened
     //    prior to attachment.
     GetContentClient()->browser()->GuestWebContentsAttached(
         guest->GetWebContents(),
-        web_contents(),
+        GetWebContents(),
         extra_params);
-    guest->Attach(
-        static_cast<WebContentsImpl*>(web_contents()), params, extra_params);
+    guest->Attach(GetWebContents(), params, extra_params);
     return;
   }
 
   scoped_ptr<base::DictionaryValue> copy_extra_params(extra_params.DeepCopy());
   guest = GetBrowserPluginGuestManager()->CreateGuest(
-      web_contents()->GetSiteInstance(),
+      GetWebContents()->GetSiteInstance(),
       instance_id, params,
       copy_extra_params.Pass());
   if (guest) {
     GetContentClient()->browser()->GuestWebContentsAttached(
         guest->GetWebContents(),
-        web_contents(),
+        GetWebContents(),
         extra_params);
-    guest->Initialize(params, static_cast<WebContentsImpl*>(web_contents()));
+    guest->Initialize(params, GetWebContents());
   }
 }
 
 void BrowserPluginEmbedder::OnPluginAtPositionResponse(
     int instance_id, int request_id, const gfx::Point& position) {
   const std::map<int, WebContents::GetRenderViewHostCallback>::iterator
       callback_iter = pending_get_render_view_callbacks_.find(request_id);
   if (callback_iter == pending_get_render_view_callbacks_.end())
     return;
 
   RenderViewHost* render_view_host;
   BrowserPluginGuest* guest = NULL;
   if (instance_id != browser_plugin::kInstanceIDNone) {
     guest = GetBrowserPluginGuestManager()->GetGuestByInstanceID(
-                instance_id, web_contents()->GetRenderProcessHost()->GetID());
+        instance_id, GetWebContents()->GetRenderProcessHost()->GetID());
   }
 
   if (guest)
     render_view_host = guest->GetWebContents()->GetRenderViewHost();
   else  // No plugin, use embedder's RenderViewHost.
-    render_view_host = web_contents()->GetRenderViewHost();
+    render_view_host = GetWebContents()->GetRenderViewHost();
 
   callback_iter->second.Run(render_view_host, position.x(), position.y());
   pending_get_render_view_callbacks_.erase(callback_iter);
 }
 
 }  // namespace content