[calls] Consistent call protocol for calls.

[calls] Consistent call protocol for calls.

The number of actual arguments should always be available, there's no
point in trying to optimize away a simple assignment of an immediate to
a register before some calls.

The main motivation is to have a consistent state at the beginning of every
function. Currently the arguments register (i.e. rax or eax) either contains
the number of arguments or some random garbage depending on whether
the callsite decided that the callee might need the information or not.
This causes trouble with runtime implementations of functions that
do not set internal_formal_parameter_count to the DontAdaptArguments
sentinel (we don't have any of those yet), but also makes it impossible
to sanity check the arguments in the callee, because the callee doesn't
know whether the caller decided to pass the number of arguments or
random garbage.

BUG=v8:4413
LOG=n

Committed: https://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9
Cr-Commit-Position: refs/heads/master@{#30648}

[Benedikt Meurer, 2015-09-09 04:35:26]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-09 04:35:26]

Hey Jaro,

This unifies the handling of "actual number of arguments" for JSFunction calls.
It basically removes premature optimization (saving one LoadImmediate for some
calls).
Please take a look.

Thanks,
Benedikt

[Jarin, 2015-09-09 04:58:26]

lgtm

[Jarin, 2015-09-09 04:58:33]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2015-09-09 04:58:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330033002/20001

[commit-bot: I haz the power, 2015-09-09 05:01:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-09 05:01:35]

Patchset 2 (id:??) landed as
https://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9
Cr-Commit-Position: refs/heads/master@{#30648}