CertificateProviderService: Expose certificate lookup.

CertificateProviderService: Expose certificate lookup.

This certificate lookup is required for the upcoming UI changes.

BUG=514575
Committed: https://crrev.com/7c3c02b253e2b41f470543da8e51f44f8022c1e8
Cr-Commit-Position: refs/heads/master@{#348015}

[pneubeck (no reviews), 2015-09-08 09:56:52]

Patchset #1 (id:1) has been deleted

[pneubeck (no reviews), 2015-09-08 09:59:36]

Patchset #1 (id:20001) has been deleted

[pneubeck (no reviews), 2015-09-08 10:01:19]

pneubeck@chromium.org changed reviewers:
+ emaxx@chromium.org

[pneubeck (no reviews), 2015-09-08 10:01:19]

Had to change the certificate map a bit. ptal.

[emaxx, 2015-09-08 14:58:56]

lgtm

https://codereview.chromium.org/1330003002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
(right):

https://codereview.chromium.org/1330003002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/certificate_provider/certificate_provider_service.h:137:
bool* has_extension,
I'd suggest renaming "has_extension" to something like "is_currently_provided".
This would probably make its meaning clearer here, and also in
ThreadSafeCertificateMap::LookUpCertificate() it wouldn't look like *info
argument is populated when *has_extension is false.

[pneubeck (no reviews), 2015-09-09 08:57:16]

Also added unit tests for the new function.

https://codereview.chromium.org/1330003002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
(right):

https://codereview.chromium.org/1330003002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/certificate_provider/certificate_provider_service.h:137:
bool* has_extension,
On 2015/09/08 14:58:56, emaxx wrote:
> I'd suggest renaming "has_extension" to something like
"is_currently_provided".
> This would probably make its meaning clearer here, and also in
> ThreadSafeCertificateMap::LookUpCertificate() it wouldn't look like *info
> argument is populated when *has_extension is false.

Done.

[pneubeck (no reviews), 2015-09-09 14:43:49]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2015-09-09 14:43:50]

The patchset sent to the CQ was uploaded after l-g-t-m from emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/1330003002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-09 14:44:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330003002/60001

[commit-bot: I haz the power, 2015-09-09 14:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 14:57:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pneubeck (no reviews), 2015-09-09 21:34:33]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2015-09-09 21:35:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330003002/60001

[commit-bot: I haz the power, 2015-09-09 21:40:20]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-09-09 21:40:58]

Patchset 2 (id:??) landed as
https://crrev.com/7c3c02b253e2b41f470543da8e51f44f8022c1e8
Cr-Commit-Position: refs/heads/master@{#348015}

[commit-bot: I haz the power, 2015-09-23 12:03:51]

Patchset 2 (id:??) landed as
https://crrev.com/7c3c02b253e2b41f470543da8e51f44f8022c1e8
Cr-Commit-Position: refs/heads/master@{#348015}