Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328203002: Fix ScopedPtrMap with custom Compare. (Closed)

Created:
5 years, 3 months ago by pneubeck (no reviews)
Modified:
5 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ScopedPtrMap with custom Compare. Copy operator, assignment operator and swap ignored the Compare template argument. BUG=529201 Committed: https://crrev.com/759762f2fb102b1a38c3d31eabf57d63048640aa Cr-Commit-Position: refs/heads/master@{#348005}

Patch Set 1 #

Patch Set 2 : Added unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M base/containers/scoped_ptr_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/containers/scoped_ptr_map_unittest.cc View 1 1 chunk +20 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1232553003 Patch 670001

Dependent Patchsets:

Issue 1330003002 Patch 60001

Messages

Total messages: 10 (2 generated)
pneubeck (no reviews)
ptal . This blocks another CL of mine which uses the ScopedPtrMap.
5 years, 3 months ago (2015-09-08 09:48:51 UTC) #2
danakj
Can you add a unit test that would fail without this change?
5 years, 3 months ago (2015-09-08 18:25:35 UTC) #3
pneubeck (no reviews)
Added unit tests. Without the change these don't compile.
5 years, 3 months ago (2015-09-09 08:14:56 UTC) #4
danakj
LGTM
5 years, 3 months ago (2015-09-09 17:45:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328203002/20001
5 years, 3 months ago (2015-09-09 20:38:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 21:11:31 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/759762f2fb102b1a38c3d31eabf57d63048640aa Cr-Commit-Position: refs/heads/master@{#348005}
5 years, 3 months ago (2015-09-09 21:12:06 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:03:24 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/759762f2fb102b1a38c3d31eabf57d63048640aa
Cr-Commit-Position: refs/heads/master@{#348005}

Powered by Google App Engine
This is Rietveld 408576698