Issue 132993002: app_shell: Fix PrefsTabHelper dependency of ExtensionHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132993002: app_shell: Fix PrefsTabHelper dependency of ExtensionHost (Closed)

Created:
6 years, 11 months ago by James Cook

Modified:
6 years, 11 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

app_shell: Fix PrefsTabHelper dependency of ExtensionHost The default preference values are fine for app_shell's pages (as they are for content_shell, which doesn't use PrefsTabHelper). Delegate out the creation of PrefsTabHelper so we only create them in Chrome. With this patch app_shell can launch a renderer before crashing. BUG=332435 TEST=browser_tests, manual testing that extensions still work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244236

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -2 lines)			Patch
M	apps/shell/shell_extensions_browser_client.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	apps/shell/shell_extensions_browser_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	extensions/browser/extensions_browser_client.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/132993002/1

6 years, 11 months ago (2014-01-10 17:31:39 UTC) #3

Message was sent while issue was closed.

Change committed as 244236

Expand Messages | Collapse Messages