Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: apps/shell/shell_extensions_browser_client.cc

Issue 132993002: app_shell: Fix PrefsTabHelper dependency of ExtensionHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/shell/shell_extensions_browser_client.h" 5 #include "apps/shell/shell_extensions_browser_client.h"
6 6
7 #include "apps/shell/shell_app_sorting.h" 7 #include "apps/shell/shell_app_sorting.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/prefs/pref_service_factory.h" 9 #include "base/prefs/pref_service_factory.h"
10 #include "base/prefs/testing_pref_store.h" 10 #include "base/prefs/testing_pref_store.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 bool ShellExtensionsBrowserClient::DeferLoadingBackgroundHosts( 89 bool ShellExtensionsBrowserClient::DeferLoadingBackgroundHosts(
90 BrowserContext* context) const { 90 BrowserContext* context) const {
91 return false; 91 return false;
92 } 92 }
93 93
94 bool ShellExtensionsBrowserClient::IsBackgroundPageAllowed( 94 bool ShellExtensionsBrowserClient::IsBackgroundPageAllowed(
95 BrowserContext* context) const { 95 BrowserContext* context) const {
96 return true; 96 return true;
97 } 97 }
98 98
99 void ShellExtensionsBrowserClient::OnExtensionHostCreated(
100 content::WebContents* web_contents) {
101 }
102
99 bool ShellExtensionsBrowserClient::DidVersionUpdate(BrowserContext* context) { 103 bool ShellExtensionsBrowserClient::DidVersionUpdate(BrowserContext* context) {
100 // TODO(jamescook): We might want to tell extensions when app_shell updates. 104 // TODO(jamescook): We might want to tell extensions when app_shell updates.
101 return false; 105 return false;
102 } 106 }
103 107
104 scoped_ptr<extensions::AppSorting> 108 scoped_ptr<extensions::AppSorting>
105 ShellExtensionsBrowserClient::CreateAppSorting() { 109 ShellExtensionsBrowserClient::CreateAppSorting() {
106 return scoped_ptr<extensions::AppSorting>(new ShellAppSorting).Pass(); 110 return scoped_ptr<extensions::AppSorting>(new ShellAppSorting).Pass();
107 } 111 }
108 112
109 bool ShellExtensionsBrowserClient::IsRunningInForcedAppMode() { 113 bool ShellExtensionsBrowserClient::IsRunningInForcedAppMode() {
110 return false; 114 return false;
111 } 115 }
112 116
113 content::JavaScriptDialogManager* 117 content::JavaScriptDialogManager*
114 ShellExtensionsBrowserClient::GetJavaScriptDialogManager() { 118 ShellExtensionsBrowserClient::GetJavaScriptDialogManager() {
115 // TODO(jamescook): Create a JavaScriptDialogManager or reuse the one from 119 // TODO(jamescook): Create a JavaScriptDialogManager or reuse the one from
116 // content_shell. 120 // content_shell.
117 NOTREACHED(); 121 NOTREACHED();
118 return NULL; 122 return NULL;
119 } 123 }
120 124
121 } // namespace apps 125 } // namespace apps
OLDNEW
« no previous file with comments | « apps/shell/shell_extensions_browser_client.h ('k') | chrome/browser/extensions/chrome_extensions_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698