Make SkGraphics::Term a no-op, stop calling it.

Make SkGraphics::Term a no-op, stop calling it.

I'd remove it entirely but Android is calling it explicitly.

BUG=skia:4259
Committed: https://skia.googlesource.com/skia/+/925979f733fe8e70d84627147dee04d030423349

Committed: https://skia.googlesource.com/skia/+/fe81e2d274a4948491ed6d4bbce1c96ea0c8f9cd

[mtklein_C, 2015-09-08 17:49:03]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2015-09-08 17:50:54]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 17:51:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329853005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329853005/1

[commit-bot: I haz the power, 2015-09-08 17:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 17:52:13]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein_C, 2015-09-08 17:53:41]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 17:53:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329853005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329853005/20001

[scroggo, 2015-09-08 17:57:28]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2015-09-08 17:57:29]

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h
File include/core/SkGraphics.h (right):

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h#n...
include/core/SkGraphics.h:165: class SkAutoGraphics {
It seems like this should go on the chopping block next.

Actually, it seems like this can go away now? It does not appear that Android
uses it. (It calls Term() directly)

[scroggo, 2015-09-08 17:57:30]

lgtm

[commit-bot: I haz the power, 2015-09-08 17:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 17:58:25]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-09-08 21:42:40]

lgtm

[mtklein, 2015-09-08 22:17:19]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-09-08 22:17:20]

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h
File include/core/SkGraphics.h (right):

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h#n...
include/core/SkGraphics.h:165: class SkAutoGraphics {
On 2015/09/08 17:57:28, scroggo wrote:
> It seems like this should go on the chopping block next.
> 
> Actually, it seems like this can go away now? It does not appear that Android
> uses it. (It calls Term() directly)

Yes and no.  As an alias for SkGraphics::Init(), SkAutoGraphics is certainly on
the chopping block.

SkGraphics::Init() itself does non-zero stuff when Skia is compiled with
SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0.
By default,  SK_ALLOW_STATIC_GLOBAL_INITIALIZERS is 1, but it's set to zero in
two cases:
  - Chrome
  - our GYPs when skia_os is Android

I'm not sure if that's intended to be, when we're building for the Android
framework, or if there's something even about our local Android builds that
makes global constructors impossible.  I don't see any uses of SkAutoGraphics
outside our test tools, so if we can sort out that Android question, we should
be fine to just delete SkAutoGraphics outright.

[mtklein, 2015-09-08 22:17:33]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-08 22:17:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329853005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329853005/20001

[commit-bot: I haz the power, 2015-09-08 22:18:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/925979f733fe8e70d84627147dee04d030423349

[mtklein, 2015-09-09 14:21:53]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1314483006/ by mtklein@google.com.

The reason for reverting is: SK_ATTR_DEPRECATED is meaningful to Android.  Don't
use it..

[scroggo, 2015-09-09 14:22:48]

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h
File include/core/SkGraphics.h (right):

https://codereview.chromium.org/1329853005/diff/1/include/core/SkGraphics.h#n...
include/core/SkGraphics.h:165: class SkAutoGraphics {
On 2015/09/08 22:17:20, mtklein wrote:
> On 2015/09/08 17:57:28, scroggo wrote:
> > It seems like this should go on the chopping block next.
> > 
> > Actually, it seems like this can go away now? It does not appear that
Android
> > uses it. (It calls Term() directly)
> 
> Yes and no.  As an alias for SkGraphics::Init(), SkAutoGraphics is certainly
on
> the chopping block.
> 
> SkGraphics::Init() itself does non-zero stuff when Skia is compiled with
> SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0.
> By default,  SK_ALLOW_STATIC_GLOBAL_INITIALIZERS is 1, but it's set to zero in
> two cases:
>   - Chrome
>   - our GYPs when skia_os is Android
> 
> I'm not sure if that's intended to be, when we're building for the Android
> framework, or if there's something even about our local Android builds that
> makes global constructors impossible.  I don't see any uses of SkAutoGraphics
> outside our test tools, so if we can sort out that Android question, we should
> be fine to just delete SkAutoGraphics outright.

Oh, I agree that we cannot necessarily remove SkGraphics::Init. SkAutoGraphics
was only interesting because it had a destructor.

[mtklein, 2015-09-09 14:29:12]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-09-09 14:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1329853005/#ps40001
(title: "remove deprecation")

[commit-bot: I haz the power, 2015-09-09 14:29:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329853005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329853005/40001

[commit-bot: I haz the power, 2015-09-09 14:35:46]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/fe81e2d274a4948491ed6d4bbce1c96ea0c8f9cd