Make SkGraphics::Term a no-op, stop calling it.

include/core/SkGraphics.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkGraphics_DEFINED
 #define SkGraphics_DEFINED
 
 #include "SkTypes.h"
 
 class SkData;
 class SkImageGenerator;
 class SkTraceMemoryDump;
 
 class SK_API SkGraphics {
 public:
     /**
      *  Call this at process initialization time if your environment does not
      *  permit static global initializers that execute code.
      *  Init() is thread-safe and idempotent.
      */
     static void Init();
 
-    /**
-     *  Call this to release any memory held privately, such as the font cache.
-     */
-    static void Term();
+    SK_ATTR_DEPRECATED("SkGraphics::Term() is a no-op.  We're in the middle of cleaning it up.")
+    static void Term() {}
 
     /**
      *  Return the version numbers for the library. If the parameter is not
      *  null, it is set to the version number.
      */
     static void GetVersion(int32_t* major, int32_t* minor, int32_t* patch);
 
     /**
      *  Return the max number of bytes that should be used by the font cache.
      *  If the cache needs to allocate more, it will purge previous entries.
@@ skipping 117 matching lines @@
      *  To instantiate images from encoded data, first looks at this runtime function-ptr. If it
      *  exists, it is called to create an SkImageGenerator from SkData. If there is no function-ptr
      *  or there is, but it returns NULL, then skia will call its internal default implementation.
      *
      *  Returns the previous factory (which could be NULL).
      */
     static ImageGeneratorFromEncodedFactory
            SetImageGeneratorFromEncodedFactory(ImageGeneratorFromEncodedFactory);
 };
 
 class SkAutoGraphics {

[scroggo, 2015/09/08 17:57:28]

It seems like this should go on the chopping block next.

Actually, it seems like this can go away now? It does not appear that Android
uses it. (It calls Term() directly)

[mtklein, 2015/09/08 22:17:20]

Yes and no.  As an alias for SkGraphics::Init(), SkAutoGraphics is certainly on
the chopping block.

SkGraphics::Init() itself does non-zero stuff when Skia is compiled with
SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0.
By default,  SK_ALLOW_STATIC_GLOBAL_INITIALIZERS is 1, but it's set to zero in
two cases:
  - Chrome
  - our GYPs when skia_os is Android

I'm not sure if that's intended to be, when we're building for the Android
framework, or if there's something even about our local Android builds that
makes global constructors impossible.  I don't see any uses of SkAutoGraphics
outside our test tools, so if we can sort out that Android question, we should
be fine to just delete SkAutoGraphics outright.

[scroggo, 2015/09/09 14:22:48]

Oh, I agree that we cannot necessarily remove SkGraphics::Init. SkAutoGraphics
was only interesting because it had a destructor.

 public:
     SkAutoGraphics() {
         SkGraphics::Init();
     }
-    ~SkAutoGraphics() {
-        SkGraphics::Term();
-    }
 };
 
 #endif