Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1329463002: rename ImportUriContributor to UriContributor (Closed)

Created:
5 years, 3 months ago by danrubel
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge and address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -655 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 1 chunk +0 lines, -184 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/uri_contributor.dart View 2 chunks +5 lines, -5 lines 0 comments Download
D pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart View 1 chunk +0 lines, -455 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 1 3 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/uri_contributor_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 3 months ago (2015-08-31 19:50:40 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1329463002/diff/1/pkg/analysis_server/test/services/completion/test_all.dart File pkg/analysis_server/test/services/completion/test_all.dart (right): https://codereview.chromium.org/1329463002/diff/1/pkg/analysis_server/test/services/completion/test_all.dart#newcode16 pkg/analysis_server/test/services/completion/test_all.dart:16: import 'uri_contributor_test.dart' as import_uri_test; Update prefix too? (We ...
5 years, 3 months ago (2015-08-31 20:23:17 UTC) #3
danrubel
https://codereview.chromium.org/1329463002/diff/1/pkg/analysis_server/test/services/completion/test_all.dart File pkg/analysis_server/test/services/completion/test_all.dart (right): https://codereview.chromium.org/1329463002/diff/1/pkg/analysis_server/test/services/completion/test_all.dart#newcode16 pkg/analysis_server/test/services/completion/test_all.dart:16: import 'uri_contributor_test.dart' as import_uri_test; On 2015/08/31 20:23:16, Brian Wilkerson ...
5 years, 3 months ago (2015-09-01 15:10:39 UTC) #4
danrubel
5 years, 3 months ago (2015-09-01 15:11:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
07184f6cdddfb26225f7312b3ac3651f9d2cf39b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698