Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1329313002: Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessin… (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
reed2, robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessing the same GrContext to read back GPU input data BUG=chromium:524717 TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/eb662bc407cec0585a821946fef123102cae64db Committed: https://skia.googlesource.com/skia/+/6c6f65885ba20ba9e8d8c36039f1c9eff4cc814b

Patch Set 1 #

Patch Set 2 : Handle reentrance #

Patch Set 3 : minor #

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M include/gpu/GrContext.h View 1 2 3 chunks +19 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 5 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329313002/1
5 years, 3 months ago (2015-09-09 23:32:33 UTC) #2
bsalomon
5 years, 3 months ago (2015-09-09 23:32:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 23:37:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329313002/1
5 years, 3 months ago (2015-09-10 01:04:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/eb662bc407cec0585a821946fef123102cae64db
5 years, 3 months ago (2015-09-10 01:05:06 UTC) #9
reed2
lgtm
5 years, 3 months ago (2015-09-10 01:33:31 UTC) #11
bsalomon
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1334603002/ by bsalomon@google.com. ...
5 years, 3 months ago (2015-09-10 01:57:34 UTC) #12
bsalomon
PTAL
5 years, 3 months ago (2015-09-10 14:01:59 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329313002/60001
5 years, 3 months ago (2015-09-10 14:39:11 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-10 14:44:00 UTC) #18
robertphillips
lgtm
5 years, 3 months ago (2015-09-10 15:03:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329313002/60001
5 years, 3 months ago (2015-09-10 15:12:04 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 15:12:50 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6c6f65885ba20ba9e8d8c36039f1c9eff4cc814b

Powered by Google App Engine
This is Rietveld 408576698