Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1329293003: [runtime] Sanitize %NewClosure runtime entries. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Sanitize %NewClosure runtime entries. There are now two runtime entries %NewClosure and %NewClosure_Tenured, with the same signature (one parameter, the SharedFunctionInfo, and the context of the caller). Also remove the HFunctionLiteral special case instruction from Crankshaft, as HCallWithDescriptor with FastNewClosureStub or HCallRuntime with either %NewClosure or %NewClosure_Tenured can easily do that for you. Also remove the redundant context parameter from the JSCreateClosure operator, because every JS operator already takes a context input. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg Committed: https://crrev.com/6b3c070db6e1e2e631f265410f540ec1a6df92ee Cr-Commit-Position: refs/heads/master@{#30671}

Patch Set 1 #

Patch Set 2 : REBASE. Ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -449 lines) Patch
M src/arm/lithium-arm.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +19 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -51 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/mips64/lithium-mips64.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/ppc/lithium-ppc.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/x87/lithium-x87.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329293003/40001
5 years, 3 months ago (2015-09-10 05:30:12 UTC) #3
Benedikt Meurer
Hey Michi, Removing another 400 lines of unnecessary code, and simplifying the runtime entries for ...
5 years, 3 months ago (2015-09-10 06:05:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-10 06:53:03 UTC) #7
Michael Starzinger
LGTM. I like it.
5 years, 3 months ago (2015-09-10 08:33:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329293003/40001
5 years, 3 months ago (2015-09-10 08:33:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-10 08:36:04 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 08:36:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b3c070db6e1e2e631f265410f540ec1a6df92ee
Cr-Commit-Position: refs/heads/master@{#30671}

Powered by Google App Engine
This is Rietveld 408576698