src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1329293003: [runtime] Sanitize %NewClosure runtime entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1329293003: [runtime] Sanitize %NewClosure runtime entries. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Ports Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 8af4a7ae5fc69a718cfdbf17e3dc3e384574ecba..a7715707f19eaab5f97daf90838152de251b556c 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1172,12 +1172,9 @@ void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,

__ mov(ebx, Immediate(info));

__ CallStub(&stub);

} else {

- __ push(esi);

__ push(Immediate(info));

- __ push(Immediate(pretenure

- ? isolate()->factory()->true_value()

- : isolate()->factory()->false_value()));

- __ CallRuntime(Runtime::kNewClosure, 3);

+ __ CallRuntime(

+ pretenure ? Runtime::kNewClosure_Tenured : Runtime::kNewClosure, 1);

}

context()->Plug(eax);

}