Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1329283002: add picture-image variant (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename new gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M gm/verylargebitmap.cpp View 1 4 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
reed1
alt version to exercise generator images (using picture in this case). This is meant to ...
5 years, 3 months ago (2015-09-09 18:11:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329283002/1
5 years, 3 months ago (2015-09-09 18:11:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 18:17:03 UTC) #6
robertphillips
lgtm + question https://codereview.chromium.org/1329283002/diff/1/gm/verylargebitmap.cpp File gm/verylargebitmap.cpp (right): https://codereview.chromium.org/1329283002/diff/1/gm/verylargebitmap.cpp#newcode122 gm/verylargebitmap.cpp:122: DEF_GM( return new VeryLargeBitmapGM(make_raster_image, "bitmap"); ) ...
5 years, 3 months ago (2015-09-09 18:21:05 UTC) #7
reed1
On 2015/09/09 18:21:05, robertphillips wrote: > lgtm + question > > https://codereview.chromium.org/1329283002/diff/1/gm/verylargebitmap.cpp > File gm/verylargebitmap.cpp ...
5 years, 3 months ago (2015-09-09 18:22:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329283002/20001
5 years, 3 months ago (2015-09-09 18:23:33 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 18:29:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7628967820994c383f2f01d1c64440488d5d8308

Powered by Google App Engine
This is Rietveld 408576698