Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1329243002: Excluded sysroot directories from checklicences.py (Closed)

Created:
5 years, 3 months ago by Adrian Kuegel
Modified:
5 years, 3 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Excluded sysroot directories from checklicences.py BUG= Committed: https://crrev.com/dce8e5667768b4e59a6507d327ee6861c777d900 Cr-Commit-Position: refs/heads/master@{#347893}

Patch Set 1 #

Patch Set 2 : Add a excluded path list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M tools/checklicenses/checklicenses.py View 1 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Adrian Kuegel
PTAL
5 years, 3 months ago (2015-09-09 09:03:08 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 3 months ago (2015-09-09 09:17:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329243002/20001
5 years, 3 months ago (2015-09-09 09:17:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 09:28:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dce8e5667768b4e59a6507d327ee6861c777d900 Cr-Commit-Position: refs/heads/master@{#347893}
5 years, 3 months ago (2015-09-09 09:29:35 UTC) #7
Sam Clegg
On 2015/09/09 09:29:35, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 3 months ago (2015-09-09 09:51:33 UTC) #8
Adrian Kuegel
5 years, 3 months ago (2015-09-09 09:55:16 UTC) #9
Message was sent while issue was closed. 
On 2015/09/09 09:51:33, Sam Clegg wrote:
> On 2015/09/09 09:29:35, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/dce8e5667768b4e59a6507d327ee6861c777d900
> > Cr-Commit-Position: refs/heads/master@{#347893}
> 
> How was this working previously?  We've been using these sysroots on the
> official builders forever and they have not been complaining.

Not sure how it worked before, but Pawel suggested to do this change. This will
also allow us to reland https://codereview.chromium.org/1317973005 .

Powered by Google App Engine
This is Rietveld 408576698