Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1317973005: Fix typo in install-sysroot.py (Closed)

Created:
5 years, 3 months ago by Sam Clegg
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_sysroot_settings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in install-sysroot.py install-sysroot.py was intended to default to installing the sysroot ia32, but within this script 'i386' is used to refer to this architecture. This most likely went unnoticed since the ia32 builder either use branding=Official, or explicitly set use_sysroot=1, or have a complete set of packages for cross building on the host system. BUG=504446 Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 Cr-Commit-Position: refs/heads/master@{#347821}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Sam Clegg
5 years, 3 months ago (2015-09-08 11:07:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973005/20001
5 years, 3 months ago (2015-09-08 11:07:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 11:24:30 UTC) #6
Dirk Pranke
looks like a bug, alright. lgtm.
5 years, 3 months ago (2015-09-08 20:18:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973005/20001
5 years, 3 months ago (2015-09-08 22:55:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 23:02:56 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 Cr-Commit-Position: refs/heads/master@{#347821}
5 years, 3 months ago (2015-09-08 23:03:28 UTC) #11
chrishtr
5 years, 3 months ago (2015-09-08 23:57:38 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1315773003/ by chrishtr@chromium.org.

The reason for reverting is: Caused check_licenses to fail:

https://build.chromium.org/p/chromium/builders/Linux/builds/66701

.

Powered by Google App Engine
This is Rietveld 408576698