Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 132923004: In HObjectAccess::ForField pass property name down into HObjectAccess for in-object fields. (Closed)

Created:
6 years, 11 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

In HObjectAccess::ForField pass property name down into HObjectAccess for in-object fields. This makes hydrogen.cfg more readable (property name becomes visible in addition to offset). R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
PTAL This is just a minor tweak to improve hydrogen.cfg output.
6 years, 11 months ago (2014-01-23 13:58:36 UTC) #1
mvstanton
Always a good thing! lgtm.
6 years, 11 months ago (2014-01-23 14:10:38 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 11 months ago (2014-01-23 14:20:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698