Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 132923004: In HObjectAccess::ForField pass property name down into HObjectAccess for in-object fields. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4327 matching lines...) Expand 10 before | Expand all | Expand 10 after
4338 index = transition->instance_descriptors()->GetFieldIndex(descriptor) - 4338 index = transition->instance_descriptors()->GetFieldIndex(descriptor) -
4339 map->inobject_properties(); 4339 map->inobject_properties();
4340 PropertyDetails details = 4340 PropertyDetails details =
4341 transition->instance_descriptors()->GetDetails(descriptor); 4341 transition->instance_descriptors()->GetDetails(descriptor);
4342 representation = details.representation(); 4342 representation = details.representation();
4343 } 4343 }
4344 if (index < 0) { 4344 if (index < 0) {
4345 // Negative property indices are in-object properties, indexed 4345 // Negative property indices are in-object properties, indexed
4346 // from the end of the fixed part of the object. 4346 // from the end of the fixed part of the object.
4347 int offset = (index * kPointerSize) + map->instance_size(); 4347 int offset = (index * kPointerSize) + map->instance_size();
4348 return HObjectAccess(kInobject, offset, representation); 4348 return HObjectAccess(kInobject, offset, representation, name);
4349 } else { 4349 } else {
4350 // Non-negative property indices are in the properties array. 4350 // Non-negative property indices are in the properties array.
4351 int offset = (index * kPointerSize) + FixedArray::kHeaderSize; 4351 int offset = (index * kPointerSize) + FixedArray::kHeaderSize;
4352 return HObjectAccess(kBackingStore, offset, representation, name); 4352 return HObjectAccess(kBackingStore, offset, representation, name);
4353 } 4353 }
4354 } 4354 }
4355 4355
4356 4356
4357 HObjectAccess HObjectAccess::ForCellPayload(Isolate* isolate) { 4357 HObjectAccess HObjectAccess::ForCellPayload(Isolate* isolate) {
4358 return HObjectAccess( 4358 return HObjectAccess(
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
4439 break; 4439 break;
4440 case kExternalMemory: 4440 case kExternalMemory:
4441 stream->Add("[external-memory]"); 4441 stream->Add("[external-memory]");
4442 break; 4442 break;
4443 } 4443 }
4444 4444
4445 stream->Add("@%d", offset()); 4445 stream->Add("@%d", offset());
4446 } 4446 }
4447 4447
4448 } } // namespace v8::internal 4448 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698