PDF: Use chrome.resourcesPrivate instead of Pepper to display translated strings

PDF: Use chrome.resourcesPrivate instead of Pepper to display translated strings

This new API is significantly simpler, and easier to add new strings to.

BUG=506035
Committed: https://crrev.com/5c0b09e2e9f54ced8a020dc2d9ae381089d7a049
Cr-Commit-Position: refs/heads/master@{#349611}

[tsergeant, 2015-09-17 03:46:12]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[tsergeant, 2015-09-17 03:46:13]

Raymes, PTAL. Almost entirely just deleting things =D

[raymes, 2015-09-17 03:56:43]

lgtm!! 

With some nits.

https://codereview.chromium.org/1329213002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/1329213002/diff/20001/chrome/browser/resource...
chrome/browser/resources/pdf/pdf.js:528: handleStrings_: function(strings) {
nit: add some jsdoc

https://codereview.chromium.org/1329213002/diff/20001/components/pdf/renderer...
File components/pdf/renderer/pepper_pdf_host.cc (left):

https://codereview.chromium.org/1329213002/diff/20001/components/pdf/renderer...
components/pdf/renderer/pepper_pdf_host.cc:8: #include
"components/strings/grit/components_strings.h"
nit: can we remove this now?

https://codereview.chromium.org/1329213002/diff/20001/components/pdf/renderer...
components/pdf/renderer/pepper_pdf_host.cc:29: #include
"ui/base/l10n/l10n_util.h"
I think we can remove this too

https://codereview.chromium.org/1329213002/diff/20001/components/pdf/renderer...
components/pdf/renderer/pepper_pdf_host.cc:31: #include
"ui/base/resource/resource_bundle.h"
We might not need this either

[tsergeant, 2015-09-17 04:23:19]

tsergeant@chromium.org changed reviewers:
+ benwells@chromium.org

[tsergeant, 2015-09-17 04:23:19]

benwells@chromium.org, please review changes in

chrome/browser/extensions/DEPS
chrome/common/extensions/api/resources_private.idl

I'm an owner of 
chrome/browser/extensions/api/resources_private/resources_private_api.cc, is it
worth me being a per-file owner of the idl file as well for these trivial enum
changes?

[tsergeant, 2015-09-17 06:43:04]

tsergeant@chromium.org changed reviewers:
+ blundell@chromium.org, dcheng@chromium.org

[tsergeant, 2015-09-17 06:43:04]

Also adding dcheng@ for ppapi_messages.h,

and blundell@ for the addition of  components/strings/grit/components_strings.h
to chrome/browser/extensions/DEPS

[blundell, 2015-09-17 07:35:33]

lgtm

[dcheng, 2015-09-17 17:10:26]

rs lgtm

yay for deletions.

[benwells, 2015-09-18 01:34:23]

On 2015/09/17 04:23:19, tsergeant wrote:
> mailto:benwells@chromium.org, please review changes in
> 
> chrome/browser/extensions/DEPS
> chrome/common/extensions/api/resources_private.idl
^^^ lgtm

> 
> I'm an owner of 
> chrome/browser/extensions/api/resources_private/resources_private_api.cc, is
it
> worth me being a per-file owner of the idl file as well for these trivial enum
> changes?

sgtm. As it is a private API I can't see anything wrong with that :)

[tsergeant, 2015-09-18 01:54:45]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2015-09-18 01:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org,
benwells@chromium.org, dcheng@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1329213002/#ps80001
(title: "Add per-file owner")

[commit-bot: I haz the power, 2015-09-18 01:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329213002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329213002/80001

[tsergeant, 2015-09-18 01:56:46]

The CQ bit was unchecked by tsergeant@chromium.org

[tsergeant, 2015-09-18 03:17:14]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2015-09-18 03:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, raymes@chromium.org, dcheng@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1329213002/#ps100001
(title: "Remove test cases")

[commit-bot: I haz the power, 2015-09-18 03:17:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329213002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329213002/100001

[commit-bot: I haz the power, 2015-09-18 04:10:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-18 04:10:51]

Patchset 6 (id:??) landed as
https://crrev.com/5c0b09e2e9f54ced8a020dc2d9ae381089d7a049
Cr-Commit-Position: refs/heads/master@{#349611}