chrome/browser/resources/pdf/manifest.json - Issue 1329213002: PDF: Use chrome.resourcesPrivate instead of Pepper to display translated strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/manifest.json

Issue 1329213002: PDF: Use chrome.resourcesPrivate instead of Pepper to display translated strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@i18n_api

Patch Set: Remove test cases Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/resources_private/resources_private_api.cc ('k') | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/manifest.json

diff --git a/chrome/browser/resources/pdf/manifest.json b/chrome/browser/resources/pdf/manifest.json

index 97404de1aa6c6caa7291b6a4bb96e60b0e219689..11a0b999e1735143d7e444dab0167ee2ef21419d 100644

--- a/chrome/browser/resources/pdf/manifest.json

+++ b/chrome/browser/resources/pdf/manifest.json

@@ -8,7 +8,8 @@

"offline_enabled": true,

"incognito": "split",

"permissions": [

- "<all_urls>"

+ "<all_urls>",

+ "resourcesPrivate"

"mime_types": [

"application/pdf"

« no previous file with comments | « chrome/browser/extensions/api/resources_private/resources_private_api.cc ('k') | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »