hide the input method window when the user is done typing

hide the input method window when the user is done typing

BUG=340100
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248903

[hush (inactive), 2014-02-02 06:58:58]

Hi! Please take a look

[benm (inactive), 2014-02-03 11:30:32]

Thanks Hush!

can we add a testcase to AdapterInputConnectionTest.java ?

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
(right):

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:229:
// User is done typing, hide the keyboard
nit: period at the end, and maybe better if the comment is inside the if block.

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:231:
|| actionCode == EditorInfo.IME_ACTION_SEARCH || isActive()) {
should this be if ((actionCode == ... || actionCode == ... ) && isActive())?

[hush (inactive), 2014-02-03 18:50:28]

Hi!
I ran the tests and it succeeded.
W   63s Main  Running tests with 1 test runners.
# 02/03/14 10:43:09: am instrument -e class
'org.chromium.content.browser.input.AdapterInputConnectionTest#testSetComposingText'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 02/03/14 10:43:11: am instrument -e class
'org.chromium.content.browser.input.AdapterInputConnectionTest#testSelectionUpdatesDuringBatch'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 02/03/14 10:43:13: am instrument -e class
'org.chromium.content.browser.input.AdapterInputConnectionTest#testDismissInputMethodWindowAfterFinishingTyping'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
C   69s Main 
********************************************************************************
C   69s Main  Summary
C   69s Main 
********************************************************************************
C   69s Main  ALL (3 tests)
C   69s Main  PASS (3 tests)
C   69s Main  FAIL (0 tests): []
C   69s Main  CRASH (0 tests): []
C   69s Main  TIMEOUT (0 tests): []
C   69s Main  UNKNOWN (0 tests): []
C   69s Main 
********************************************************************************

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
(right):

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:229:
// User is done typing, hide the keyboard
On 2014/02/03 11:30:33, benm wrote:
> nit: period at the end, and maybe better if the comment is inside the if
block.

Done.

https://codereview.chromium.org/132913007/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:231:
|| actionCode == EditorInfo.IME_ACTION_SEARCH || isActive()) {
On 2014/02/03 11:30:33, benm wrote:
> should this be if ((actionCode == ... || actionCode == ... ) && isActive())?

Yes. That's right
Done.

[benm (inactive), 2014-02-04 14:48:30]

Thanks for the test! +aurimas to take a look as well.

Please update the issue description to remove WebView, this is a change in
behavior for Chrome on Android too.

[hush (inactive), 2014-02-04 17:12:24]

On 2014/02/04 14:48:30, benm wrote:
> Thanks for the test! +aurimas to take a look as well.
> 
> Please update the issue description to remove WebView, this is a change in
> behavior for Chrome on Android too.

Done.
Thanks!

[aurimas (slooooooooow), 2014-02-04 17:14:28]

lgtm

[benm (inactive), 2014-02-04 18:57:50]

lgtm

[hush (inactive), 2014-02-04 20:44:13]

The CQ bit was checked by hush@chromium.org

[commit-bot: I haz the power, 2014-02-04 21:00:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hush@chromium.org/132913007/70001

[commit-bot: I haz the power, 2014-02-04 23:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 23:11:49]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[hush (inactive), 2014-02-05 04:32:30]

Hi Jared,
I need your LGTM to commit. The commit bot fails at the moment.
Can you take a look?
Thanks

[jdduke (slow), 2014-02-05 05:23:55]

On 2014/02/05 04:32:30, hush wrote:
> Hi Jared,
> I need your LGTM to commit. The commit bot fails at the moment.
> Can you take a look?
> Thanks

lgtm

[jdduke (slow), 2014-02-05 05:24:03]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-02-05 05:33:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hush@chromium.org/132913007/70001

[commit-bot: I haz the power, 2014-02-05 07:36:42]

Change committed as 248903