content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java - Issue 132913007: hide the input method window when the user is done typing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 132913007: hide the input method window when the user is done typing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

index 05d04c1bde47e79b8a42d6af365aadcb91f737a7..369d5edda617d28afa4459ab8bf87f1ac1bfefe2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

@@ -225,6 +225,13 @@ public class AdapterInputConnection extends BaseInputConnection {

mImeAdapter.sendKeyEventWithKeyCode(KeyEvent.KEYCODE_ENTER,

KeyEvent.FLAG_SOFT_KEYBOARD | KeyEvent.FLAG_KEEP_TOUCH_MODE

| KeyEvent.FLAG_EDITOR_ACTION);

+ if ((actionCode == EditorInfo.IME_ACTION_GO || actionCode == EditorInfo.IME_ACTION_DONE

+ || actionCode == EditorInfo.IME_ACTION_SEARCH) && isActive()) {

+ // User is done typing, hide the keyboard.

+ InputMethodManagerWrapper wrapper = getInputMethodManagerWrapper();

+ wrapper.hideSoftInputFromWindow(mInternalView.getWindowToken(), 0, null);

+ }

}

return true;

}