Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132903015: Deprecate MediaError.MEDIA_ERR_ENCRYPTED (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, arv+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : deprecate #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/MediaError.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-28 09:23:38 UTC) #1
ddorwin
LGTM with comment https://codereview.chromium.org/132903015/diff/1/Source/core/html/MediaError.idl File Source/core/html/MediaError.idl (right): https://codereview.chromium.org/132903015/diff/1/Source/core/html/MediaError.idl#newcode33 Source/core/html/MediaError.idl:33: [RuntimeEnabled=EncryptedMediaAnyVersion, MeasureAs=MediaErrorEncrypted] const unsigned short MEDIA_ERR_ENCRYPTED ...
6 years, 10 months ago (2014-01-28 19:17:47 UTC) #2
philipj_slow
On 2014/01/28 19:17:47, ddorwin wrote: > LGTM with comment > > https://codereview.chromium.org/132903015/diff/1/Source/core/html/MediaError.idl > File Source/core/html/MediaError.idl ...
6 years, 10 months ago (2014-01-29 06:10:53 UTC) #3
ojan
lgtm
6 years, 10 months ago (2014-01-29 18:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/132903015/1
6 years, 10 months ago (2014-01-29 18:03:23 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9776
6 years, 10 months ago (2014-01-29 23:52:23 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 23:53:57 UTC) #7
philipj_slow
This now deprecates as well, so PTAL to see if the deprecation message is to ...
6 years, 10 months ago (2014-01-30 07:27:28 UTC) #8
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-01-30 18:04:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/132903015/20001
6 years, 10 months ago (2014-01-30 18:52:30 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10029
6 years, 10 months ago (2014-01-30 23:00:32 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 23:00:40 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 23:00:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/132903015/40001
6 years, 10 months ago (2014-01-31 07:42:09 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24927
6 years, 10 months ago (2014-01-31 10:47:04 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 10:47:09 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 10:47:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/132903015/40001
6 years, 10 months ago (2014-01-31 10:48:57 UTC) #18
commit-bot: I haz the power
Change committed as 166206
6 years, 10 months ago (2014-01-31 12:39:54 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 12:39:57 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 12:40:02 UTC) #21
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698