Chromium Code Reviews Chromium Code Reviews
Issue
1329013002:
Revert of Add inline style in the element's scope. (Closed)
DescriptionRevert of Add inline style in the element's scope. (patchset #1 id:1 of https://codereview.chromium.org/1322753006/ )
Reason for revert:
This caused regression.
https://code.google.com/p/chromium/issues/detail?id=528370
Original issue's description:
> Add inline style in the element's scope.
>
> Style attribute declarations were added in a separate scope after all
> other author origins. Instead add style attribute declarations right after
> collecting matching rules from the element's scope. This means that we can
> override values set on the style attribute from outer scopes, like we can
> with values from inner scope's stylesheet.
>
> Without this fix, you would get green on orange below:
>
> <style>html /deep/ span { color: green; background-color: lime }</style>
> <host>
> <host:root>
> <style>span { color:red }</style>
> <span style="background:orange">Green on orange?</span>
> </host:root>
> </host>
>
> With this change, we will get green on lime.
>
> The regression (issue 526634) was not relying on this, but it would be
> more complex code to fix the regression without fixing the style attribute
> cascading order.
>
> R=kochi@chromium.org,hayato@chromium.org
> BUG=526634
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201620
TBR=hayato@chromium.org,rune@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526634
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201842
Patch Set 1 #
Messages
Total messages: 4 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
