Pass through channel layout on OSX if hardware supports it.

Pass through channel layout on OSX if hardware supports it.

Allows OSX to handle remapping channels according to a user's
preferences instead of forcing us to handle it.

BUG=266674
TEST=Multichannel users report proper output.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244306

[DaleCurtis, 2014-01-10 20:10:37]

Spreading the code review love.

[xhwang, 2014-01-10 22:05:05]

lgtm % one nit

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:655: const bool valid_input_params =
input_params.IsValid();
valid_input_params
vs
input_params.IsValid()

I found input_params.IsValid() clearer than |valid_input_params|. Really we only
saved four characters :)

[DaleCurtis, 2014-01-10 22:08:39]

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:655: const bool valid_input_params =
input_params.IsValid();
On 2014/01/10 22:05:05, xhwang wrote:
> valid_input_params
> vs
> input_params.IsValid()
> 
> I found input_params.IsValid() clearer than |valid_input_params|. Really we
only
> saved four characters :)

Since it's a "complex" method which isn't suitable for hacker_style(), getting
IsValid() once and reusing the value in both checks is better practice (IMHO).

[xhwang, 2014-01-10 22:40:43]

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:655: const bool valid_input_params =
input_params.IsValid();
On 2014/01/10 22:08:39, DaleCurtis wrote:
> On 2014/01/10 22:05:05, xhwang wrote:
> > valid_input_params
> > vs
> > input_params.IsValid()
> > 
> > I found input_params.IsValid() clearer than |valid_input_params|. Really we
> only
> > saved four characters :)
> 
> Since it's a "complex" method which isn't suitable for hacker_style(), getting
> IsValid() once and reusing the value in both checks is better practice (IMHO).

That's a valid point :) How about name is to is_input_params_valid so that it
doesn't sounds like a noun?

[DaleCurtis, 2014-01-10 22:49:50]

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/132873002/diff/120001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:655: const bool valid_input_params =
input_params.IsValid();
On 2014/01/10 22:40:43, xhwang wrote:
> On 2014/01/10 22:08:39, DaleCurtis wrote:
> > On 2014/01/10 22:05:05, xhwang wrote:
> > > valid_input_params
> > > vs
> > > input_params.IsValid()
> > > 
> > > I found input_params.IsValid() clearer than |valid_input_params|. Really
we
> > only
> > > saved four characters :)
> > 
> > Since it's a "complex" method which isn't suitable for hacker_style(),
getting
> > IsValid() once and reusing the value in both checks is better practice
(IMHO).
> 
> That's a valid point :) How about name is to is_input_params_valid so that it
> doesn't sounds like a noun?

Renamed to "has_valid_input_params"

[xhwang, 2014-01-10 23:01:37]

lgtm++, thanks!

[commit-bot: I haz the power, 2014-01-10 23:40:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/132873002/200001

[commit-bot: I haz the power, 2014-01-11 02:13:37]

Change committed as 244306