Pass through channel layout on OSX if hardware supports it.

media/audio/mac/audio_manager_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_manager_mac.h"
 
 #include <CoreAudio/AudioHardware.h>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 626 matching lines @@
     stream = new AUAudioInputStream(this, params, output_params,
         audio_device_id);
   }
 
   return stream;
 }
 
 AudioParameters AudioManagerMac::GetPreferredOutputStreamParameters(
     const std::string& output_device_id,
     const AudioParameters& input_params) {
-  AudioDeviceID device = GetAudioDeviceIdByUId(false, output_device_id);
+  const AudioDeviceID device = GetAudioDeviceIdByUId(false, output_device_id);
   if (device == kAudioObjectUnknown) {
     DLOG(ERROR) << "Invalid output device " << output_device_id;
     return input_params.IsValid() ? input_params : AudioParameters(
         AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_STEREO,
         kFallbackSampleRate, 16, ChooseBufferSize(kFallbackSampleRate));
   }
 
-  int hardware_channels = 2;
+  const bool valid_input_params = input_params.IsValid();

[xhwang, 2014/01/10 22:05:05]

valid_input_params
vs
input_params.IsValid()

I found input_params.IsValid() clearer than |valid_input_params|. Really we only
saved four characters :)

[DaleCurtis, 2014/01/10 22:08:39]

Since it's a "complex" method which isn't suitable for hacker_style(), getting
IsValid() once and reusing the value in both checks is better practice (IMHO).

[xhwang, 2014/01/10 22:40:43]

That's a valid point :) How about name is to is_input_params_valid so that it
doesn't sounds like a noun?

[DaleCurtis, 2014/01/10 22:49:50]

Renamed to "has_valid_input_params"

+  const int hardware_sample_rate = HardwareSampleRateForDevice(device);
+  const int buffer_size = ChooseBufferSize(hardware_sample_rate);
+
+  int hardware_channels;
   if (!GetDeviceChannels(device, kAudioDevicePropertyScopeOutput,
                          &hardware_channels)) {
-    // Fallback to stereo.
     hardware_channels = 2;
   }
 
-  ChannelLayout channel_layout = GuessChannelLayout(hardware_channels);
-
-  const int hardware_sample_rate = HardwareSampleRateForDevice(device);
-  const int buffer_size = ChooseBufferSize(hardware_sample_rate);
-
-  int input_channels = 0;
-  if (input_params.IsValid()) {
-    input_channels = input_params.input_channels();
-
-    if (input_channels > 0) {
-      // TODO(xians): given the limitations of the AudioOutputStream
-      // back-ends used with synchronized I/O, we hard-code to stereo.
-      // Specifically, this is a limitation of AudioSynchronizedStream which
-      // can be removed as part of the work to consolidate these back-ends.
-      channel_layout = CHANNEL_LAYOUT_STEREO;
-    }
+  // Use the input channel count and channel layout if possible.  Let OSX take
+  // care of remapping the channels; this lets user specified channel layouts
+  // work correctly.
+  int output_channels = input_params.channels();
+  ChannelLayout channel_layout = input_params.channel_layout();
+  if (!valid_input_params || output_channels > hardware_channels) {
+    output_channels = hardware_channels;
+    channel_layout = GuessChannelLayout(output_channels);
+    if (channel_layout == CHANNEL_LAYOUT_UNSUPPORTED)
+      channel_layout = CHANNEL_LAYOUT_DISCRETE;
   }
 
-  if (channel_layout == CHANNEL_LAYOUT_UNSUPPORTED)
-    channel_layout = CHANNEL_LAYOUT_DISCRETE;
-  else
-    hardware_channels = ChannelLayoutToChannelCount(channel_layout);
+  const int input_channels =
+      valid_input_params ? input_params.input_channels() : 0;
+  if (input_channels > 0) {
+    // TODO(xians): given the limitations of the AudioOutputStream
+    // back-ends used with synchronized I/O, we hard-code to stereo.
+    // Specifically, this is a limitation of AudioSynchronizedStream which
+    // can be removed as part of the work to consolidate these back-ends.
+    channel_layout = CHANNEL_LAYOUT_STEREO;
+  }
 
-  AudioParameters params(
-      AudioParameters::AUDIO_PCM_LOW_LATENCY,
-      channel_layout,
-      hardware_channels,
-      input_channels,
-      hardware_sample_rate,
-      16,
-      buffer_size,
+  return AudioParameters(
+      AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout, output_channels,
+      input_channels, hardware_sample_rate, 16, buffer_size,
       AudioParameters::NO_EFFECTS);
-
-  return params;
 }
 
 void AudioManagerMac::CreateDeviceListener() {
   DCHECK(GetTaskRunner()->BelongsToCurrentThread());
 
   // Get a baseline for the sample-rate and current device,
   // so we can intelligently handle device notifications only when necessary.
   current_sample_rate_ = HardwareSampleRate();
   if (!GetDefaultOutputDevice(&current_output_device_))
     current_output_device_ = kAudioDeviceUnknown;
@@ skipping 42 matching lines @@
   }
 
   return buffer_size;
 }
 
 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) {
   return new AudioManagerMac(audio_log_factory);
 }
 
 }  // namespace media