Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328693002: Drop special-case handling of zero-length subpaths (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, blink-reviews-rendering, f(malita), slimming-paint-reviews_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org, _cary
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop special-case handling of zero-length subpaths Handled by Skia with https://codereview.chromium.org/1314213002 BUG=422974, 529845 Committed: https://crrev.com/65730d791b7bedfc547a29cea6659ddc792e9ddf git-svn-id: svn://svn.chromium.org/blink/trunk@202056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Rebase; TEs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -214 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGPath.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGPath.cpp View 4 chunks +0 lines, -64 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/layout/svg/SVGSubpathData.h View 1 chunk +0 lines, -99 lines 0 comments Download
M Source/core/paint/SVGShapePainter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 3 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
I just saw https://codereview.chromium.org/1336543002 landing, should we revert that and use these TE updates instead ...
5 years, 3 months ago (2015-09-10 14:17:02 UTC) #2
fs
On 2015/09/10 14:17:02, fs wrote: > I just saw https://codereview.chromium.org/1336543002 landing, should we revert > ...
5 years, 3 months ago (2015-09-10 14:18:07 UTC) #3
f(malita)
Awesome cleanup, thank you both! LGTM
5 years, 3 months ago (2015-09-10 14:22:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328693002/20001
5 years, 3 months ago (2015-09-10 14:32:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202056
5 years, 3 months ago (2015-09-10 15:00:38 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:10:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/65730d791b7bedfc547a29cea6659ddc792e9ddf

Powered by Google App Engine
This is Rietveld 408576698