Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1314213002: zero-length cap fix (Closed)

Created:
4 years, 6 months ago by caryclark
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

zero-length cap fix Re-land; layout tests are suppressed and gm differences are understood. A merge conflict prevented a automatic reland. If the endcap is not butt, draw the endcaps even when the line has zero length. If the dash length is zero, generate a zero length line segment. Treat a move followed by a close as a move followed by a zero-length line. TBR=reed@google.com BUG=422974 Committed: https://skia.googlesource.com/skia/+/5cb00a95734143ca068960ead1ae94d0440c61da

Patch Set 1 #

Patch Set 2 : add gm test decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -11 lines) Patch
M gm/strokes.cpp View 1 3 chunks +80 lines, -6 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M src/core/SkStroke.cpp View 4 chunks +21 lines, -2 lines 0 comments Download
M src/utils/SkDashPath.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314213002/20001
4 years, 6 months ago (2015-08-26 16:00:07 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2015-08-26 16:04:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5cb00a95734143ca068960ead1ae94d0440c61da

Powered by Google App Engine
This is Rietveld 408576698