chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java - Issue 1328663003: [Custom tab]Fix a bug that clicking media notification opens blank tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 1328663003: [Custom tab]Fix a bug that clicking media notification opens blank tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

index eb5ce0a5ee21cb4a868219063ee6f19bc910b9fe..320a7797a70b84b413395148ac462d7eaa81bff0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.media.ui;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.Log;

import org.chromium.chrome.browser.UrlUtilities;

+import org.chromium.chrome.browser.customtabs.CustomTab;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabObserver;

@@ -81,6 +82,7 @@ public class MediaSessionTabHelper {

origin,

mTab.getId(),

mTab.isIncognito(),

+ mTab instanceof CustomTab,

mControlsListener));

}

};