Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java

Issue 1328663003: [Custom tab]Fix a bug that clicking media notification opens blank tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
index 6a2ed42d280db6daf90a65bff6f514b4cd8247b7..7710d3cfe50ce4362e0cc139ca9981c9f83ac959 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
@@ -41,6 +41,11 @@ public class MediaNotificationInfo {
public final MediaPlaybackListener listener;
/**
+ * Whether the media belongs to a custom tab.
gone 2015/09/02 21:55:17 media notification
Ian Wen 2015/09/02 22:00:14 Done.
+ */
+ public final boolean isCustomTab;
gone 2015/09/02 21:55:17 isForCustomTab?
Ian Wen 2015/09/02 22:00:14 Done.
+
+ /**
* Create a new MediaNotificationInfo.
* @param title
* @param state
@@ -54,12 +59,14 @@ public class MediaNotificationInfo {
String origin,
int tabId,
boolean isPrivate,
+ boolean isCustomTab,
MediaPlaybackListener listener) {
this.title = title;
this.isPaused = isPaused;
this.origin = origin;
this.tabId = tabId;
this.isPrivate = isPrivate;
+ this.isCustomTab = isCustomTab;
this.listener = listener;
}
@@ -73,6 +80,7 @@ public class MediaNotificationInfo {
other.origin,
other.tabId,
other.isPrivate,
+ other.isCustomTab,
other.listener);
}

Powered by Google App Engine
This is Rietveld 408576698