Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328653002: Introduce V8GCController::collectAllGarbage (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
sof
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, vivekg_samsung, tzik, kinuko+serviceworker, nhiroki, falken, vivekg, blink-reviews-bindings_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce V8GCController::collectAllGarbage Currently each call site is calling V8GCController:collectGarbage multiple times to collect all V8 & Blink objects. We should have a helper method that does this. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201774

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThreadTest.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerManagerTest.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLeakDetector.cpp View 1 3 chunks +2 lines, -8 lines 0 comments Download
M Source/web/tests/WebUnitTests.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
haraken
PTAL
5 years, 3 months ago (2015-09-02 10:50:20 UTC) #2
sof
lgtm https://codereview.chromium.org/1328653002/diff/1/Source/web/tests/WebUnitTests.cpp File Source/web/tests/WebUnitTests.cpp (right): https://codereview.chromium.org/1328653002/diff/1/Source/web/tests/WebUnitTests.cpp#newcode58 Source/web/tests/WebUnitTests.cpp:58: V8GCController::collectAllGarbage(v8::Isolate::GetCurrent()); This might flush out some current unit ...
5 years, 3 months ago (2015-09-02 11:06:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328653002/1
5 years, 3 months ago (2015-09-02 11:07:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/107103)
5 years, 3 months ago (2015-09-02 12:03:41 UTC) #7
haraken
I need to land https://codereview.chromium.org/1312583007/ first.
5 years, 3 months ago (2015-09-03 01:51:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328653002/20001
5 years, 3 months ago (2015-09-04 03:58:31 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 05:01:46 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201774

Powered by Google App Engine
This is Rietveld 408576698