Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: Source/modules/compositorworker/CompositorWorkerManagerTest.cpp

Issue 1328653002: Introduce V8GCController::collectAllGarbage (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/compositorworker/CompositorWorkerManagerTest.cpp
diff --git a/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp b/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp
index 6c8c234da9a78dbc584ba8f861cdc5ebeb11291b..ff8fe0359e27242342492f1713d6f3fd553b5553 100644
--- a/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp
+++ b/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp
@@ -6,6 +6,7 @@
#include "modules/compositorworker/CompositorWorkerManager.h"
#include "bindings/core/v8/ScriptSourceCode.h"
+#include "bindings/core/v8/V8GCController.h"
#include "core/inspector/ConsoleMessage.h"
#include "core/testing/DummyPageHolder.h"
#include "core/workers/WorkerLoaderProxy.h"
@@ -14,12 +15,11 @@
#include "modules/compositorworker/CompositorWorkerThread.h"
#include "platform/NotImplemented.h"
#include "platform/ThreadSafeFunctional.h"
-#include "platform/heap/Heap.h"
+#include "platform/heap/Handle.h"
#include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
#include "public/platform/WebWaitableEvent.h"
#include <gtest/gtest.h>
-#include <v8.h>
namespace blink {
namespace {
@@ -53,8 +53,7 @@ private:
}
void willDestroyIsolate() override
{
- v8::Isolate::GetCurrent()->RequestGarbageCollectionForTesting(v8::Isolate::kFullGarbageCollection);
- Heap::collectAllGarbage();
+ V8GCController::collectAllGarbageForTesting(v8::Isolate::GetCurrent());
CompositorWorkerThread::willDestroyIsolate();
}
« no previous file with comments | « Source/core/workers/WorkerThreadTest.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698