Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1328623002: Returning const ref instead of const value in QuicStreamRequest::origin_host (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 3 months ago
Reviewers:
eroman, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning const ref instead of const value in QuicStreamRequest::origin_host BUG=393155 Committed: https://crrev.com/d4e2adf17eb0e38657d242d72e6a25bb772c4986 Cr-Commit-Position: refs/heads/master@{#346851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_stream_factory.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
shiva.jm
pls have a look.
5 years, 3 months ago (2015-09-02 04:12:00 UTC) #2
eroman
LGTM, however you also need to add yourself to the AUTHORS file.
5 years, 3 months ago (2015-09-02 05:00:12 UTC) #3
shiva.jm
On 2015/09/02 05:00:12, eroman wrote: > LGTM, however you also need to add yourself to ...
5 years, 3 months ago (2015-09-02 05:14:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328623002/1
5 years, 3 months ago (2015-09-02 05:27:27 UTC) #6
eroman
lgtm
5 years, 3 months ago (2015-09-02 06:34:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 06:35:09 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:35:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e2adf17eb0e38657d242d72e6a25bb772c4986
Cr-Commit-Position: refs/heads/master@{#346851}

Powered by Google App Engine
This is Rietveld 408576698