net/quic/quic_stream_factory.h - Issue 1328623002: Returning const ref instead of const value in QuicStreamRequest::origin_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.h

Issue 1328623002: Returning const ref instead of const value in QuicStreamRequest::origin_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_factory.h

diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h

index 199d200ff280ed2f049dab4ba8e67c19ee90e30f..b1dd20a0542a09e6f4b58890bfdad5e72d5ae396 100644

--- a/net/quic/quic_stream_factory.h

+++ b/net/quic/quic_stream_factory.h

@@ -74,7 +74,7 @@ class NET_EXPORT_PRIVATE QuicStreamRequest {

void set_stream(scoped_ptr<QuicHttpStream> stream);

- const std::string origin_host() const { return origin_host_; }

+ const std::string& origin_host() const { return origin_host_; }

PrivacyMode privacy_mode() const { return privacy_mode_; }

« no previous file with comments | « no previous file | no next file » | no next file with comments »