Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 1328573003: Revert of Componentizing chrome/browser/services/gcm/gcm_desktop_utils.cc. (Closed)

Created:
5 years, 3 months ago by pneubeck (no reviews)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Componentizing chrome/browser/services/gcm/gcm_desktop_utils.cc. (patchset #4 id:60001 of https://codereview.chromium.org/1325063002/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/5215 Original issue's description: > Componentizing chrome/browser/services/gcm/gcm_desktop_utils.cc. > > Moved chrome/browser/services/gcm/gcm_desktop_utils.* to > components/gcm_driver/. > Added a extra param version_info to CreateGCMDriverDesktop() > for resolving the bad dependancy from chrome. > > BUG=519579 > > Committed: https://crrev.com/ae5abc9a10333564b9e30c5fc1013f97e19ff4e0 > Cr-Commit-Position: refs/heads/master@{#347128} TBR=droger@chromium.org,zea@chromium.org,thestig@chromium.org,jitendra.ks@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=519579 Committed: https://crrev.com/ceab06ffd994490f396c9684ca24b8edf05af679 Cr-Commit-Position: refs/heads/master@{#347130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -191 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -15 lines 0 comments Download
A chrome/browser/services/gcm/gcm_desktop_utils.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/services/gcm/gcm_desktop_utils.cc View 1 chunk +115 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M components/gcm_driver/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/gcm_driver/gcm_desktop_utils.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/gcm_driver/gcm_desktop_utils.cc View 1 chunk +0 lines, -106 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
Created Revert of Componentizing chrome/browser/services/gcm/gcm_desktop_utils.cc.
5 years, 3 months ago (2015-09-03 10:09:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328573003/1
5 years, 3 months ago (2015-09-03 10:09:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 10:10:18 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 10:10:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceab06ffd994490f396c9684ca24b8edf05af679
Cr-Commit-Position: refs/heads/master@{#347130}

Powered by Google App Engine
This is Rietveld 408576698