Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1328333002: Use #if DCHECK_IS_ON() in base/strings/string_piece.* (Closed)

Created:
5 years, 3 months ago by Olli Raula
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use #if DCHECK_IS_ON() in base/strings/string_piece.* Use #if DCHECK_IS_ON() instead of (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) in base/strings/string_piece.* because it is same thing and more succinct and centralized. Committed: https://crrev.com/570930fc8fdb676b9a60fb4d4a7b029569518da9 Cr-Commit-Position: refs/heads/master@{#353605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/strings/string_piece.h View 3 chunks +3 lines, -2 lines 0 comments Download
M base/strings/string_piece.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Olli Raula
Could you review?
5 years, 2 months ago (2015-10-12 14:07:15 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-12 22:00:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328333002/1
5 years, 2 months ago (2015-10-12 22:02:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 22:11:06 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 22:11:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/570930fc8fdb676b9a60fb4d4a7b029569518da9
Cr-Commit-Position: refs/heads/master@{#353605}

Powered by Google App Engine
This is Rietveld 408576698