Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3233)

Unified Diff: base/strings/string_piece.cc

Issue 1328333002: Use #if DCHECK_IS_ON() in base/strings/string_piece.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/string_piece.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/string_piece.cc
diff --git a/base/strings/string_piece.cc b/base/strings/string_piece.cc
index 99975725afcc1d7d5dc104b076be55e674d031b1..db0433aed152462c21ce63c3053d79038b14eb96 100644
--- a/base/strings/string_piece.cc
+++ b/base/strings/string_piece.cc
@@ -435,7 +435,7 @@ StringPiece16 substr(const StringPiece16& self,
return substrT(self, pos, n);
}
-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
+#if DCHECK_IS_ON()
void AssertIteratorsInOrder(std::string::const_iterator begin,
std::string::const_iterator end) {
DCHECK(begin <= end) << "StringPiece iterators swapped or invalid.";
« no previous file with comments | « base/strings/string_piece.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698