[DevTools] Allow stars in blocked url pattern.

[DevTools] Allow stars in blocked url pattern.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201947

[dgozman, 2015-09-08 22:22:23]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[dgozman, 2015-09-08 22:22:23]

PTAL

[caseq, 2015-09-08 23:02:15]

https://codereview.chromium.org/1328273003/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorResourceAgent.cpp (right):

https://codereview.chromium.org/1328273003/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorResourceAgent.cpp:103: size_t pos = 0;
move down to actual usage?

https://codereview.chromium.org/1328273003/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorResourceAgent.cpp:109: pos =
url.find(pattern.substring(done, index - done));
So a*b*c would match "bac", right?

https://codereview.chromium.org/1328273003/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorResourceAgent.cpp:112: pos = pos + index - done;
what is the effect of this?

[caseq, 2015-09-08 23:04:17]

https://codereview.chromium.org/1328273003/diff/1/LayoutTests/http/tests/insp...
File LayoutTests/http/tests/inspector/network/network-blocked-reason.html
(right):

https://codereview.chromium.org/1328273003/diff/1/LayoutTests/http/tests/insp...
LayoutTests/http/tests/inspector/network/network-blocked-reason.html:51:
blockedSetting.set(["http://some.strange.origin/script.js",
"resources**/silent*.js*"]);
Can we please have a more extensive test for that?

[dgozman, 2015-09-09 00:49:27]

PTAL

[caseq, 2015-09-09 00:54:42]

lgtm

https://codereview.chromium.org/1328273003/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/inspector/network/network-blocked-reason.html
(right):

https://codereview.chromium.org/1328273003/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/inspector/network/network-blocked-reason.html:33:
InspectorTest.addResult("BlockedReason: " + request.blockedReason());
nit: I'd put it in a more readable form, i.e. Blocked: true/false

https://codereview.chromium.org/1328273003/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorResourceAgent.cpp (right):

https://codereview.chromium.org/1328273003/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorResourceAgent.cpp:426: fprintf(stderr, "matches:
%s -> %s -> %d\n", url.utf8().data(), entry.key.utf8().data(), matches(url,
entry.key));
please remove this.

[dgozman, 2015-09-09 00:56:54]

https://codereview.chromium.org/1328273003/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/inspector/network/network-blocked-reason.html
(right):

https://codereview.chromium.org/1328273003/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/inspector/network/network-blocked-reason.html:33:
InspectorTest.addResult("BlockedReason: " + request.blockedReason());
On 2015/09/09 00:54:42, caseq wrote:
> nit: I'd put it in a more readable form, i.e. Blocked: true/false

There are more reasons than just inspector.

https://codereview.chromium.org/1328273003/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorResourceAgent.cpp (right):

https://codereview.chromium.org/1328273003/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorResourceAgent.cpp:426: fprintf(stderr, "matches:
%s -> %s -> %d\n", url.utf8().data(), entry.key.utf8().data(), matches(url,
entry.key));
On 2015/09/09 00:54:42, caseq wrote:
> please remove this.

Hmm... I thought presubmit catches fprintf.

[dgozman, 2015-09-09 00:58:12]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-09-09 00:58:12]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1328273003/#ps40001
(title: "fprintf")

[commit-bot: I haz the power, 2015-09-09 00:58:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328273003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328273003/40001

[commit-bot: I haz the power, 2015-09-09 02:10:47]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201947