[DevTools] Allow stars in blocked url pattern.

Source/core/inspector/InspectorResourceAgent.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 77 matching lines @@
 static const char userAgentOverride[] = "userAgentOverride";
 static const char monitoringXHR[] = "monitoringXHR";
 static const char blockedURLs[] = "blockedURLs";
 }
 
 namespace {
 
 // Keep in sync with kDevToolsRequestInitiator defined in devtools_network_controller.cc
 const char kDevToolsEmulateNetworkConditionsClientId[] = "X-DevTools-Emulate-Network-Conditions-Client-Id";
 
+// Pattern may contain stars ('*') which match to any (possibly empty) string.
+// Stars implicitly assumed at the begin/end of pattern.
+bool matches(const String& url, const String& pattern)
+{
+    size_t done = 0;
+    size_t pos = 0;

[caseq, 2015/09/08 23:02:14]

move down to actual usage?

+    while (done < pattern.length()) {
+        size_t index = pattern.find('*', done);
+        if (index == kNotFound)
+            index = pattern.length();
+        if (index > done) {
+            pos = url.find(pattern.substring(done, index - done));

[caseq, 2015/09/08 23:02:14]

So a*b*c would match "bac", right?

+            if (pos == kNotFound)
+                return false;
+            pos = pos + index - done;

[caseq, 2015/09/08 23:02:14]

what is the effect of this?

+        }
+        done = index + 1;
+    }
+    return true;
+}
+
 static PassRefPtr<JSONObject> buildObjectForHeaders(const HTTPHeaderMap& headers)
 {
     RefPtr<JSONObject> headersObject = JSONObject::create();
     for (const auto& header : headers)
         headersObject->setString(header.key.string(), header.value);
     return headersObject;
 }
 
 class InspectorFileReaderLoaderClient final : public FileReaderLoaderClient {
     WTF_MAKE_NONCOPYABLE(InspectorFileReaderLoaderClient);
@@ skipping 292 matching lines @@
     visitor->trace(m_replayXHRsToBeDeleted);
     visitor->trace(m_pendingXHRReplayData);
     InspectorBaseAgent::trace(visitor);
 }
 
 bool InspectorResourceAgent::shouldBlockRequest(const ResourceRequest& request)
 {
     String url = request.url().string();
     RefPtr<JSONObject> blockedURLs = m_state->getObject(ResourceAgentState::blockedURLs);
     for (const auto& entry : *blockedURLs) {
-        if (url.contains(entry.key))
+        if (matches(url, entry.key))
             return true;
     }
     return false;
 }
 
 void InspectorResourceAgent::didBlockRequest(LocalFrame* frame, const ResourceRequest& request, DocumentLoader* loader, const FetchInitiatorInfo& initiatorInfo, ResourceRequestBlockedReason reason)
 {
     unsigned long identifier = createUniqueIdentifier();
     willSendRequestInternal(frame, identifier, loader, request, ResourceResponse(), initiatorInfo);
 
@@ skipping 662 matching lines @@
     , m_removeFinishedReplayXHRTimer(this, &InspectorResourceAgent::removeFinishedReplayXHRFired)
 {
 }
 
 bool InspectorResourceAgent::shouldForceCORSPreflight()
 {
     return m_state->getBoolean(ResourceAgentState::cacheDisabled);
 }
 
 } // namespace blink