Always ignore submodules.

Always ignore submodules.

R=phadjan@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245272

[Paweł Hajdan Jr., 2014-01-16 03:20:06]

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py
File gclient_scm.py (left):

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py#oldcode261
gclient_scm.py:261: cmd = ['git', 'submodule', '--quiet', 'foreach', '
'.join(submod_cmd)]
Do we still need the git submodule foreach then?

I admit I don't know git submodules that well. Just asking to understand.

[szager1, 2014-01-16 05:44:51]

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py
File gclient_scm.py (left):

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py#oldcode261
gclient_scm.py:261: cmd = ['git', 'submodule', '--quiet', 'foreach', '
'.join(submod_cmd)]
On 2014/01/16 03:20:06, Paweł Hajdan Jr. wrote:
> Do we still need the git submodule foreach then?
> 
> I admit I don't know git submodules that well. Just asking to understand.

Yes, we do; the submodule foreach command is the thing that sets the 'ignore'
config.

[Paweł Hajdan Jr., 2014-01-16 17:20:35]

LGTM

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py
File gclient_scm.py (left):

https://codereview.chromium.org/132803004/diff/1/gclient_scm.py#oldcode260
gclient_scm.py:260: 'submodule.$name.ignore', 'all']
Ah, I missed there is still submodule.$name here.

[commit-bot: I haz the power, 2014-01-16 18:53:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/132803004/1

[commit-bot: I haz the power, 2014-01-16 18:54:56]

Change committed as 245272