gclient_scm.py - Issue 132803004: Always ignore submodules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_scm.py

Issue 132803004: Always ignore submodules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index c80575e0d2fae66f8a5a134443e3bd1db3d643b2..8572f094a38befc1f5741b235b3d03f8ca51c1ff 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -255,8 +255,6 @@ class GitWrapper(SCMWrapper):

def UpdateSubmoduleConfig(self):

submod_cmd = ['git', 'config', '-f', '$toplevel/.git/config',

- 'submodule.$name.ignore', '||',

- 'git', 'config', '-f', '$toplevel/.git/config',

'submodule.$name.ignore', 'all']

Paweł Hajdan Jr. 2014/01/16 17:20:35 Ah, I missed there is still submodule.$name here.

cmd = ['git', 'submodule', '--quiet', 'foreach', ' '.join(submod_cmd)]

Paweł Hajdan Jr. 2014/01/16 03:20:06 Do we still need the git submodule foreach then?

szager1 2014/01/16 05:44:52 Yes, we do; the submodule foreach command is the t

cmd2 = ['git', 'config', 'diff.ignoreSubmodules', 'all']

« no previous file with comments | « no previous file | no next file » | no next file with comments »